Check get_header status returned #1361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
requested changes
Jun 23, 2019
be/src/olap/olap_snapshot.cpp
Outdated
| } | ||
|
|
||
| OLAPHeader* new_olap_header = new(std::nothrow) OLAPHeader(); | ||
| res = OlapHeaderManager::get_header(stores[0], tablet->tablet_id(), tablet->schema_hash(), new_olap_header); |
Contributor
There was a problem hiding this comment.
memory leak for new_olap_header
When performing storage_medium_migration, the header may be already droped. In this scenario, header returned will be null pointer. Saving data to a null pointer will cause core dump.
imay
approved these changes
Jun 23, 2019
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Feb 1, 2023
…ache#1361) * [improvement](dynamic-table) refine some logic 1. support filter malformed json lines 2. refactor block align logic
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Feb 1, 2023
…ache#1361) * [improvement](dynamic-table) refine some logic 1. support filter malformed json lines 2. refactor block align logic
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Feb 2, 2023
…ache#1361) * [improvement](dynamic-table) refine some logic 1. support filter malformed json lines 2. refactor block align logic
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Feb 7, 2023
…ache#1361) * [improvement](dynamic-table) refine some logic 1. support filter malformed json lines 2. refactor block align logic
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Feb 8, 2023
…ache#1361) * [improvement](dynamic-table) refine some logic 1. support filter malformed json lines 2. refactor block align logic
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Feb 9, 2023
…ache#1361) * [improvement](dynamic-table) refine some logic 1. support filter malformed json lines 2. refactor block align logic
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Feb 10, 2023
…ache#1361) * [improvement](dynamic-table) refine some logic 1. support filter malformed json lines 2. refactor block align logic
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Feb 10, 2023
…ache#1361) * [improvement](dynamic-table) refine some logic 1. support filter malformed json lines 2. refactor block align logic
eldenmoon
added a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Feb 10, 2023
…ache#1361) * [improvement](dynamic-table) refine some logic 1. support filter malformed json lines 2. refactor block align logic
luwei16
pushed a commit
to luwei16/Doris
that referenced
this pull request
Apr 7, 2023
…ache#1361) * [improvement](dynamic-table) refine some logic 1. support filter malformed json lines 2. refactor block align logic
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
…ache#1361) * [improvement](dynamic-table) refine some logic 1. support filter malformed json lines 2. refactor block align logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing storage_medium_migration, the header may be already droped.
In this scenario, header returned will be null pointer.
Saving data to a null pointer will cause core dump.