Skip to content

Conversation

@englefly
Copy link
Contributor

Proposed changes

Nereids use decimal(27,9) as default size.
This change is following the change in "Improvement print decimal according to the real precision and scale (#13437)"
commit: 9a3c1f0

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@Gabriel39 Gabriel39 changed the title [Improvement](nereids) nereids uses decimal(27,9) by as default deciaml [Improvement](nereids) nereids uses decimal(27,9) as default decimal Oct 26, 2022
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 26, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@jackwener jackwener merged commit ddb27b9 into apache:master Oct 26, 2022
@englefly englefly deleted the decimal_29_9 branch June 16, 2023 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/nereids kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants