Skip to content

[fix](function) fix coredump cause by return type mismatch of vectorized repeat function #13868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Nov 3, 2022
Merged

[fix](function) fix coredump cause by return type mismatch of vectorized repeat function #13868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions be/src/vec/exprs/vectorized_fn_call.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,15 @@ VectorizedFnCall::VectorizedFnCall(const doris::TExprNode& node) : VExpr(node) {

doris::Status VectorizedFnCall::prepare(doris::RuntimeState* state,
const doris::RowDescriptor& desc, VExprContext* context) {
// In 1.2-lts, repeat function return type is changed to always nullable,
// which is not compatible with 1.1-lts
if ("repeat" == _fn.name.function_name and !_data_type->is_nullable()) {
const auto error_msg =
"In progress of upgrading from 1.1-lts to 1.2-lts, vectorized repeat "
"function cannot be executed, you can switch to non-vectorized engine by "
"'set global enable_vectorized_engine = false'";
return Status::InternalError(error_msg);
}
RETURN_IF_ERROR_OR_PREPARED(VExpr::prepare(state, desc, context));
ColumnsWithTypeAndName argument_template;
argument_template.reserve(_children.size());
Expand Down