Skip to content

[Enhancement](sequence-column) optimize the use of sequence column #13872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 6 commits into from
Nov 17, 2022
Merged

[Enhancement](sequence-column) optimize the use of sequence column #13872

morningman merged 6 commits into from
Nov 17, 2022

Conversation

@liaoxin01
Copy link
Contributor

@liaoxin01 liaoxin01 commented Nov 1, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

When you create the Uniq table, you can specify the mapping of sequence column to other columns. You no longer need to specify mapping column when importing.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/docs Categorizes issue or PR as related to documentation. kind/test labels Nov 1, 2022
@liaoxin01 liaoxin01 changed the title [Enhancement][sequence-column] optimize the use of sequence column [Enhancement](sequence-column) optimize the use of sequence column Nov 1, 2022
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 1, 2022 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.05 seconds
load time: 517 seconds
storage size: 17178996618 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221110032528_clickbench_pr_43068.html

morningman
morningman reviewed Nov 2, 2022
View reviewed changes
@morningman morningman added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API api-review Categorizes an issue or PR as actively needing an API review. labels Nov 2, 2022
dataroaring
dataroaring reviewed Nov 2, 2022
View reviewed changes
@liaoxin01 liaoxin01 force-pushed the optimize_seq branch 2 times, most recently from a165dab to 06dfbe2 Compare November 3, 2022 03:14
zhannngchen
zhannngchen reviewed Nov 3, 2022
View reviewed changes
@liaoxin01 liaoxin01 force-pushed the optimize_seq branch 4 times, most recently from 96e9fcf to e9f1daa Compare November 8, 2022 10:00
@zhannngchen
Copy link
Contributor

zhannngchen commented Nov 11, 2022

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2022

PR approved by anyone and no changes requested.

morningman
morningman approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit fb140d0 into apache:master Nov 17, 2022
@morningman morningman mentioned this pull request Nov 21, 2022
Closed
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Nov 27, 2022
@liaoxin01 @FreeOnePlus
[Enhancement](sequence-column) optimize the use of sequence column (a…
7339cdf 
…pache#13872)

When you create the Uniq table, you can specify the mapping of sequence column to other columns.
You no longer need to specify mapping column when importing.
@liaoxin01 liaoxin01 deleted the optimize_seq branch February 6, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring left review comments

@morningman morningman morningman approved these changes

@zhannngchen zhannngchen zhannngchen approved these changes

Assignees

No one assigned

Labels

api-review Categorizes an issue or PR as actively needing an API review. area/planner Issues or PRs related to the query planner kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/docs Categorizes issue or PR as related to documentation. kind/test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@liaoxin01 @hello-stephen @zhannngchen @morningman @dataroaring