Acquire rs readers at the beginning of the olapscanner #1400
Conversation
| // if not clear rowset readers in read_params here | ||
| // readers will be release when runtime state deconstructed but | ||
| // deconstructor in reader references runtime state | ||
| // so that it will core |
There was a problem hiding this comment.
This comment make me confusing...
There was a problem hiding this comment.
It means, we should deconstructor resource in close method. Not in deconstructor method.
be/src/olap/reader.cpp
Outdated
| || read_params.reader_type == READER_QUERY) { | ||
| rs_readers = &read_params.rs_readers; | ||
| } else { | ||
| _tablet->obtain_header_rdlock(); |
There was a problem hiding this comment.
can this branch be deleted?
There was a problem hiding this comment.
Could not. because there is another reader_type CHECK_SUM
There was a problem hiding this comment.
Can rowsets be aquired in the same method as other types for CHECK_SUM?
Or it looks odd.
| */ | ||
| // TODO(ygl): temp modify it for test !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! | ||
| @ConfField(mutable = true, masterOnly = true) | ||
| public static long catalog_trash_expire_second = 10L; // 1day |
There was a problem hiding this comment.
you can do test by using modify configuration file.
There was a problem hiding this comment.
In the past, it is one day。。。。
be/src/exec/olap_scanner.cpp
Outdated
| // the rowsets maybe compacted when the last olap scanner starts | ||
| _tablet->obtain_header_rdlock(); | ||
| OLAPStatus acquire_reader_st = _tablet->capture_rs_readers(_params.version, &_params.rs_readers); | ||
| _tablet->release_header_lock(); |
There was a problem hiding this comment.
I think you should add a function in tablet who will encapsulate the lock and unlock operation.
There was a problem hiding this comment.
currently could not. because some times we do step 1 step 2 step 3 and step 3 is capture_rs_readers. If add lock in capture rs readers will be dead lock.
…hich cache is hit (apache#1400)
3 participants
No description provided.