Skip to content

[fix](insert) fix insert into table which contains column name prefix… #14361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 2 commits into from
Nov 21, 2022
Merged

[fix](insert) fix insert into table which contains column name prefix… #14361

yiguolei merged 2 commits into from
Nov 21, 2022

Conversation

@nextdreamblue
Copy link
Contributor

@nextdreamblue nextdreamblue commented Nov 17, 2022 •
edited
Loading

Signed-off-by: nextdreamblue zxw520blue1@163.com

Proposed changes

Issue Number: close #14334

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner kind/test labels Nov 17, 2022
@hello-stephen
Copy link
Contributor

hello-stephen commented Nov 17, 2022 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.38 seconds
load time: 510 seconds
storage size: 17170245310 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221119083840_clickbench_pr_49088.html

@nextdreamblue nextdreamblue force-pushed the insert_mv_bug branch 3 times, most recently from fc7f599 to b02f710 Compare November 18, 2022 15:00
@nextdreamblue
[fix](meta) add column name check for 'mv_'
bf6f52a 
Signed-off-by: nextdreamblue <zxw520blue1@163.com>
@nextdreamblue
fix fe ut
1016311 
Signed-off-by: nextdreamblue <zxw520blue1@163.com>
yiguolei
yiguolei approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit a9a6fdd into apache:master Nov 21, 2022
FreeOnePlus pushed a commit to FreeOnePlus/doris that referenced this pull request Nov 27, 2022
@nextdreamblue @FreeOnePlus
[fix](insert) fix insert into table which contains column name prefix…
54fb3b7 
… mv_ (apache#14361)
@morningman morningman mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

area/planner Issues or PRs related to the query planner kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] insert into table which contains column name prefix with 'mv_' error

3 participants

@nextdreamblue @hello-stephen @yiguolei