Add string function split_part #1445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| StringVal StringFunctions::split_part(FunctionContext* context,const StringVal& content, | ||
| const StringVal& delimiter,const IntVal& field) { | ||
| if (field.val <= 0) return StringVal::null(); |
Contributor
There was a problem hiding this comment.
What if content、delimiter or field is null？
imay
requested changes
Jul 9, 2019
| } | ||
|
|
||
|
|
||
| StringVal StringFunctions::split_part(FunctionContext* context,const StringVal& content, |
Contributor
There was a problem hiding this comment.
Suggested change
| StringVal StringFunctions::split_part(FunctionContext* context,const StringVal& content, | |
| StringVal StringFunctions::split_part(FunctionContext* context, const StringVal& content, |
|
|
||
|
|
||
| StringVal StringFunctions::split_part(FunctionContext* context,const StringVal& content, | ||
| const StringVal& delimiter,const IntVal& field) { |
Contributor
There was a problem hiding this comment.
Suggested change
| const StringVal& delimiter,const IntVal& field) { | |
| const StringVal& delimiter, const IntVal& field) { |
| const StringVal& delimiter,const IntVal& field) { | ||
| if (field.val <= 0) return StringVal::null(); | ||
| int find[field.val]; //store substring position | ||
| for(int i=0;i<=field.val;i++) find[i] = -1; // init |
Contributor
There was a problem hiding this comment.
Suggested change
| for(int i=0;i<=field.val;i++) find[i] = -1; // init | |
| for (int i=0;i<=field.val;i++) find[i] = -1; // init |
| int find[field.val]; //store substring position | ||
| for(int i=0;i<=field.val;i++) find[i] = -1; // init | ||
| int from = 0; | ||
| for(int i=1;i<=field.val;i++){ // find |
Contributor
There was a problem hiding this comment.
Suggested change
| for(int i=1;i<=field.val;i++){ // find | |
| for (int i=1; i<=field.val; i++) { // find |
| for(int i=0;i<=field.val;i++) find[i] = -1; // init | ||
| int from = 0; | ||
| for(int i=1;i<=field.val;i++){ // find | ||
| find[i-1] = indexOf(content.ptr,0,content.len, delimiter.ptr,0,delimiter.len,from); |
Contributor
There was a problem hiding this comment.
Suggested change
| find[i-1] = indexOf(content.ptr,0,content.len, delimiter.ptr,0,delimiter.len,from); | |
| find[i-1] = indexOf(content.ptr,0, content.len, delimiter.ptr, 0, delimiter.len, from); |
You should add one space after punctuation
| break; | ||
| } | ||
| } | ||
| if ((field.val>1 && find[field.val-2] == -1) || (field.val==1 && find[field.val-1] == -1)){ // not find |
Contributor
There was a problem hiding this comment.
Suggested change
| if ((field.val>1 && find[field.val-2] == -1) || (field.val==1 && find[field.val-1] == -1)){ // not find | |
| if ((field.val > 1 && find[field.val-2] == -1) || (field.val == 1 && find[field.val-1] == -1)){ // not find |
| if ((field.val>1 && find[field.val-2] == -1) || (field.val==1 && find[field.val-1] == -1)){ // not find | ||
| return StringVal::null(); | ||
| } | ||
| int start_pos,len; |
| return do_money_format(context, ss.str()); | ||
| } | ||
|
|
||
| static int indexOf(const uint8_t* source, int sourceOffset, int sourceCount, |
Contributor
There was a problem hiding this comment.
Suggested change
| static int indexOf(const uint8_t* source, int sourceOffset, int sourceCount, | |
| static int index_of(const uint8_t* source, int sourceOffset, int sourceCount, |
Contributor
Author
|
感谢指出问题， 我仔细修改下再提交。 |
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
… (apache#1445) * (Enhancement)[load-json] support simdjson in new json reader (apache#16903) be config: enable_simdjson_reader=true related PR apache#11665 * [Optimize](simd json reader) Cached search results for previous row (keyed as index in JSON object) - used as a hint. (apache#17124) * [Optimize](simd json reader) Cached search results for previous row (keyed as index in JSON object) - used as a hint. `_simdjson_set_column_value` could become a hot spot while parsing json in simdjson mode, introduce `_prev_positions` to cache results for previous row (keyed as index in JSON object) due to the json name field order, should be quite the same between each lines * fix case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add string function split_part. Just like postgresql