Skip to content

Conversation

@yixiutt
Copy link
Contributor

@yixiutt yixiutt commented Nov 24, 2022

1.remove quick_compaction's rowset pick policy, call cu compaction when trigger quick compaction
2. skip tablet's compaction task when compaction score is too small

Co-authored-by: yixiutt yixiu@selectdb.com

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…e#13495)

1.remove quick_compaction's rowset pick policy, call cu compaction when trigger
quick compaction
2. skip tablet's compaction task when compaction score is too small

Co-authored-by: yixiutt <yixiu@selectdb.com>
@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Nov 24, 2022
@yixiutt yixiutt changed the title (compaction) opt compaction task producer and quick compaction (#13495) [enhancement](compaction) opt compaction task producer and quick compaction (#13495) Nov 24, 2022
@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.26 seconds
load time: 447 seconds
storage size: 17169585070 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221124035832_clickbench_pr_51818.html

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

PR approved by anyone and no changes requested.

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring
Copy link
Contributor

Passes P2,so I merged it quickly.

@dataroaring dataroaring merged commit 3dde97b into apache:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/docs Categorizes issue or PR as related to documentation. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants