Skip to content

[fix](iterator) Fix leak in VCollectorIterator #14549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Nov 25, 2022
Merged

[fix](iterator) Fix leak in VCollectorIterator #14549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions be/src/vec/olap/vcollect_iterator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@ namespace vectorized {
} \
} while (false)

VCollectIterator::~VCollectIterator() {
for (auto child : _children) {
delete child;
}
}

void VCollectIterator::init(TabletReader* reader, bool force_merge, bool is_reverse) {
_reader = reader;
// when aggregate is enabled or key_type is DUP_KEYS, we don't merge
Expand Down
2 changes: 1 addition & 1 deletion be/src/vec/olap/vcollect_iterator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ namespace vectorized {
class VCollectIterator {
public:
// Hold reader point to get reader params
~VCollectIterator() = default;
~VCollectIterator();

void init(TabletReader* reader, bool force_merge, bool is_reverse);

Expand Down