Skip to content

Conversation

@FreeOnePlus
Copy link
Member

Proposed changes

Adjust the field naming rules when creating tables.

The original table field rules are letters or underscores or @ characters as the first letter, followed by a maximum of 63 characters, and the total cannot exceed 64 characters. However, in many industries, such as the financial industry, the length of the derived fields often exceeds 64 characters, so adjust the regular The rules are from 64 characters to 128 characters. Many users load data from Hive to Doris through appearance or BrokerLoad. Arabic numerals can be used as the first letter in the Hive table, so the regular rules are adjusted to support Arabic numerals as the first letter.

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.76 seconds
load time: 433 seconds
storage size: 17123343211 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221129111737_clickbench_pr_54977.html

@FreeOnePlus FreeOnePlus changed the title Adjust the field naming rules when creating tables [improvement](planner)Adjust the field naming rules when creating tables Nov 29, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 30, 2022
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 30, 2022
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit d5ee721 into apache:master Nov 30, 2022
@morningman morningman mentioned this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants