-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improvement](config) update high_priority_flush_thread_num_per_store default value to 6 #14775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement](config) update high_priority_flush_thread_num_per_store default value to 6 #14775
Conversation
|
TeamCity pipeline, clickbench performance test result: |
6800c95 to
5901187
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
5901187 to
318ef90
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
318ef90 to
98c3dde
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
98c3dde to
cac53ea
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
cac53ea to
02f7759
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
… default value to 6
02f7759 to
f7a77ec
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
… default value to 6 (apache#14775)
PraveenNanda124
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work
… default value to 6 (#14775)
Proposed changes
Issue Number: close #xxx
Problem summary
Align this config with
flush_thread_num_per_storeCurrent default value 1 is too small for the machine with single disk.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...