Skip to content

[fix](multi-catalog) use last used database for catalog when switch back #14793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 3 commits into from
Dec 8, 2022
Merged

[fix](multi-catalog) use last used database for catalog when switch back #14793

morningman merged 3 commits into from
Dec 8, 2022

Conversation

@Yulei-Yang
Copy link
Contributor

@Yulei-Yang Yulei-Yang commented Dec 3, 2022

remember last used database of every catalog and use it when switch back

Proposed changes

Issue Number: close #14792

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 3, 2022 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.3 seconds
load time: 431 seconds
storage size: 17123356301 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221207171913_clickbench_pr_59683.html

@Yulei-Yang Yulei-Yang changed the title [fix][multi-catalog] use last used database for catalog when switch back [fix](multi-catalog) use last used database for catalog when switch back Dec 3, 2022
morningman
morningman reviewed Dec 5, 2022
View reviewed changes
@github-actions github-actions bot added area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/docs Categorizes issue or PR as related to documentation. labels Dec 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

clang-tidy review says "All clean, LGTM! 👍"

morningman
morningman approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 27c8147 into apache:master Dec 8, 2022
morningman pushed a commit that referenced this pull request Dec 14, 2022
@Yulei-Yang @morningman
[fix](multi-catalog) use last used database for catalog when switch b…
efa4f52 
…ack (#14793)

remember last used database of every catalog and use it when switch back
This was referenced Jul 15, 2024
Merged
Merged
morningman pushed a commit that referenced this pull request Jul 23, 2024
@Yulei-Yang
[fix](multicatalog) make lastdbofcatalog a session variable (#37828)
591ddf7 
bring by: #14793

issue:
lastdbofcatalog is a global variable, so all login user share it. that's
not correct, should be a session variable
dataroaring pushed a commit that referenced this pull request Jul 24, 2024
@Yulei-Yang @dataroaring
[fix](multicatalog) make lastdbofcatalog a session variable (#37828)
f572190 
bring by: #14793

issue:
lastdbofcatalog is a global variable, so all login user share it. that's
not correct, should be a session variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

Assignees

No one assigned

Labels

area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization dev/1.2.1-merged kind/docs Categorizes issue or PR as related to documentation. kind/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] lost last used database when switch catalog back

4 participants

@Yulei-Yang @hello-stephen @morningman @yiguolei