Skip to content

Fix heap-buffer-overflow in split_part() function in StringFunctions #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imay merged 1 commit into from
Jul 15, 2019
Merged

Fix heap-buffer-overflow in split_part() function in StringFunctions #1482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion be/src/exprs/string_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,6 @@ StringVal StringFunctions::split_part(FunctionContext* context, const StringVal&
return StringVal::null();
}
std::vector<int> find(field.val, -1); //store substring position
for (int i = 0; i <= field.val; i++) find[i] = -1; // init
int from = 0;
for (int i = 1; i <= field.val; i++) { // find
int last_index = i - 1;
Expand Down
1 change: 0 additions & 1 deletion be/test/exprs/string_functions_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ TEST_F(StringFunctionsTest, split_part) {
}

int main(int argc, char** argv) {
doris::init_glog("be-test");
::testing::InitGoogleTest(&argc, argv);
return RUN_ALL_TESTS();
}
10 changes: 0 additions & 10 deletions be/test/util/tdigest_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,16 +59,6 @@ class TDigestTest : public ::testing::Test {
// Objects declared here can be used by all tests in the test case for Foo.
};

static double cdf(const double x, const std::vector<double>& data) {
int n1 = 0;
int n2 = 0;
for (auto v : data) {
n1 += (v < x) ? 1 : 0;
n2 += (v <= x) ? 1 : 0;
}
return (n1 + n2) / 2.0 / data.size();
}

static double quantile(const double q, const std::vector<double>& values) {
double q1;
if (values.size() == 0) {
Expand Down