Add timediff function #1505
Merged
Add timediff function #1505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think that you need't import a new udf type to implement timediff. |
imay
reviewed
Jul 19, 2019
gensrc/script/gen_functions.py
Outdated
| 'VARCHAR': 'string_val', | ||
| 'DATE': 'datetime_val', | ||
| 'DATETIME': 'datetime_val', | ||
| 'TIME': 'datetime_val', |
Contributor
There was a problem hiding this comment.
I think it's better to use bigint_val
| } | ||
| // no need to check upper bound | ||
| break; | ||
| case TIME: |
Contributor
There was a problem hiding this comment.
I think it is not fit to add type TIME in IntLiteral
| case TYPE_DATETIME: | ||
| case TYPE_TIME: { | ||
| char buf[64]; | ||
| const DateTimeValue* time_val = (const DateTimeValue*)(item); |
Contributor
There was a problem hiding this comment.
I think use bigint to represent time in memory?
HangyuanLiu
force-pushed
the
add-timediff
branch
2 times, most recently
from
403f208 to
4fb06b4
Compare
imay
reviewed
Jul 22, 2019
be/src/exprs/literal.cpp
Outdated
| _value.datetime_val.from_date_str( | ||
| node.date_literal.value.c_str(), node.date_literal.value.size()); | ||
| break; | ||
| case TYPE_TIME: |
| public: | ||
| static void init(); | ||
|
|
||
| static BooleanVal cast_to_boolean_val(FunctionContext*, const DoubleVal&); |
Contributor
There was a problem hiding this comment.
I think we can only support time to double and to string
be/src/runtime/raw_value.cpp
Outdated
| break; | ||
| } | ||
|
|
||
| case TYPE_TIME: |
Contributor
There was a problem hiding this comment.
I think this should be the same as TYPE_DOUBLE
| buf_ret = _row_buffer->push_double(*static_cast<double*>(item)); | ||
| break; | ||
|
|
||
| case TYPE_TIME: { |
Contributor
There was a problem hiding this comment.
you can write a function to do this to avoid write this many times
| case INT: | ||
| return "IntVal"; | ||
| case BIGINT: | ||
| case TIME: |
| compatibilityMatrix[DECIMALV2.ordinal()][DECIMAL.ordinal()] = DECIMALV2; | ||
|
|
||
| compatibilityMatrix[HLL.ordinal()][HLL.ordinal()] = HLL; | ||
| compatibilityMatrix[TIME.ordinal()][TIME.ordinal()] = TIME; |
Contributor
There was a problem hiding this comment.
you should add more relation between time and other types
HangyuanLiu
force-pushed
the
add-timediff
branch
7 times, most recently
from
e649d62 to
92d7b85
Compare
HangyuanLiu
force-pushed
the
add-timediff
branch
from
92d7b85 to
7118a60
Compare
morningman
pushed a commit
to baidu-doris/incubator-doris
that referenced
this pull request
Jul 28, 2019
morningman
pushed a commit
to baidu-doris/incubator-doris
that referenced
this pull request
Jul 28, 2019
merge to apache-doris 0694b6a
Closed
luwei16
pushed a commit
to luwei16/Doris
that referenced
this pull request
Apr 7, 2023
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timediff function
#1428