Skip to content

Fix bug that BE may crash when closing OlapTableSink #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imay merged 1 commit into from
Jul 19, 2019
Merged

Fix bug that BE may crash when closing OlapTableSink #1507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion be/src/exec/tablet_sink.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,9 +588,12 @@ Status OlapTableSink::send(RuntimeState* state, RowBatch* input_batch) {
}

Status OlapTableSink::close(RuntimeState* state, Status close_status) {
SCOPED_TIMER(_profile->total_time_counter());
Status status = close_status;
if (status.ok()) {
// SCOPED_TIMER should only be called is status is ok.
// if status is not ok, this OlapTableSink may not be prepared,
// so the `_profile` may be null.
SCOPED_TIMER(_profile->total_time_counter());
{
SCOPED_TIMER(_close_timer);
for (auto channel : _channels) {
Expand Down