-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL #15223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
TeamCity pipeline, clickbench performance test result: |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
… BOOL (#15223) fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson. - thirdparty/installed/include/sqltypes.h > #define BOOL int - thirdparty/src/simdjson-1.0.2/include/simdjson/dom/element.h > enum class element_type { > ARRAY = '[', ///< dom::array > OBJECT = '{', ///< dom::object > INT64 = 'l', ///< int64_t > UINT64 = 'u', ///< uint64_t: any integer that fits in uint64_t but *not* int64_t > DOUBLE = 'd', ///< double: Any number with a "." or "e" that fits in double. > STRING = '"', ///< std::string_view > BOOL = 't', ///< bool > NULL_VALUE = 'n' ///< null > }; >
…he#1331) * (improvement)[dynamic-table] support load in new_load_scan_node * [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL (apache#15223) fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson. Co-authored-by: Kang <kxiao.tiger@gmail.com>
…he#1331) * (improvement)[dynamic-table] support load in new_load_scan_node * [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL (apache#15223) fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson. Co-authored-by: Kang <kxiao.tiger@gmail.com>
…he#1331) * (improvement)[dynamic-table] support load in new_load_scan_node * [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL (apache#15223) fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson. Co-authored-by: Kang <kxiao.tiger@gmail.com>
…he#1331) * (improvement)[dynamic-table] support load in new_load_scan_node * [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL (apache#15223) fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson. Co-authored-by: Kang <kxiao.tiger@gmail.com>
…he#1331) * (improvement)[dynamic-table] support load in new_load_scan_node * [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL (apache#15223) fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson. Co-authored-by: Kang <kxiao.tiger@gmail.com>
…he#1331) * (improvement)[dynamic-table] support load in new_load_scan_node * [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL (apache#15223) fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson. Co-authored-by: Kang <kxiao.tiger@gmail.com>
…he#1331) * (improvement)[dynamic-table] support load in new_load_scan_node * [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL (apache#15223) fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson. Co-authored-by: Kang <kxiao.tiger@gmail.com>
…he#1331) * (improvement)[dynamic-table] support load in new_load_scan_node * [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL (apache#15223) fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson. Co-authored-by: Kang <kxiao.tiger@gmail.com>
…he#1331) * (improvement)[dynamic-table] support load in new_load_scan_node * [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL (apache#15223) fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson. Co-authored-by: Kang <kxiao.tiger@gmail.com>
…he#1331) * (improvement)[dynamic-table] support load in new_load_scan_node * [bugfix](thirdparty) patch simdjson to avoid conflict with odbc macro BOOL (apache#15223) fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson. Co-authored-by: Kang <kxiao.tiger@gmail.com>
Proposed changes
fix conflit name BOOL in odbc sqltypes.h and simdjson element.h. Change BOOL to BOOLEAN in simdjson.
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...