Unify ColumnSchemaV2 and ColumnSchema to one #1545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we have two versions of ColumnSchema, in this patch, we unify these two classes to one class.
chaoyli
approved these changes
Jul 25, 2019
luwei16
pushed a commit
to luwei16/Doris
that referenced
this pull request
Apr 7, 2023
… if it match inverted index (apache#18065)" (apache#1545) The optimization for skip reading column data if it match inverted index and only used in WHERE clause may get wrong result for complex SQL. This PR temporary disable the optimization and later PRs will resolve the problem fundamentality. Fix http://jira.flywheels.com:8090/browse/CORE-1739 commit d1f34a3 Author: Kang <kxiao.tiger@gmail.com> Date: Mon Mar 27 11:29:42 2023 +0800 [bugfix](inverted index)temporary disable skip read column data if it match inverted index (apache#18065) The optimization for skip reading column data if it match inverted index and only used in WHERE clause may get wrong result for complex SQL. This PR temporary disable the optimization and later PRs will resolve the problem fundamentality. Co-authored-by: Kang <kxiao.tiger@gmail.com>
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
… if it match inverted index (apache#18065)" (apache#1545) The optimization for skip reading column data if it match inverted index and only used in WHERE clause may get wrong result for complex SQL. This PR temporary disable the optimization and later PRs will resolve the problem fundamentality. Fix http://jira.flywheels.com:8090/browse/CORE-1739 commit d1f34a3 Author: Kang <kxiao.tiger@gmail.com> Date: Mon Mar 27 11:29:42 2023 +0800 [bugfix](inverted index)temporary disable skip read column data if it match inverted index (apache#18065) The optimization for skip reading column data if it match inverted index and only used in WHERE clause may get wrong result for complex SQL. This PR temporary disable the optimization and later PRs will resolve the problem fundamentality. Co-authored-by: Kang <kxiao.tiger@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we have two versions of ColumnSchema, in this patch, we unify
these two classes to one class.