Skip to content

EnginePublishVersionTask: remove unreachable code #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imay merged 1 commit into from
Jul 30, 2019
Merged

EnginePublishVersionTask: remove unreachable code #1562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 5 additions & 15 deletions be/src/olap/task/engine_publish_version_task.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,21 +104,11 @@ OLAPStatus EnginePublishVersionTask::finish() {
res = publish_status;
continue;
}
if (publish_status == OLAP_SUCCESS || publish_status == OLAP_ERR_PUSH_VERSION_ALREADY_EXIST) {
LOG(INFO) << "publish version successfully on tablet. tablet=" << tablet->full_name()
<< ", transaction_id=" << transaction_id << ", version=" << version.first
<< ", res=" << publish_status;
// delete rowset from meta env, because add inc rowset alreay saved the rowset meta to tablet meta
RowsetMetaManager::remove(tablet->data_dir()->get_meta(), tablet->tablet_uid(), rowset->rowset_id());
// delete txn info
} else {
LOG(WARNING) << "fail to publish version on tablet. tablet=" << tablet->full_name().c_str()
Copy link
Contributor

@yiguolei yiguolei Jul 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed error tablet ids

Copy link
Contributor Author

@gaodayue gaodayue Jul 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the else clause is unreachable, please see the if statement at line 97

Copy link
Contributor

@yiguolei yiguolei Jul 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry...

<< "transaction_id=" << transaction_id
<< "version=" << version.first
<< " res=" << publish_status;
_error_tablet_ids->push_back(tablet->tablet_id());
res = publish_status;
}
LOG(INFO) << "publish version successfully on tablet. tablet=" << tablet->full_name()
<< ", transaction_id=" << transaction_id << ", version=" << version.first
<< ", res=" << publish_status;
// delete rowset from meta env, because add inc rowset alreay saved the rowset meta to tablet meta
RowsetMetaManager::remove(tablet->data_dir()->get_meta(), tablet->tablet_uid(), rowset->rowset_id());
}
}

Expand Down