Skip to content

Conversation

@carlvinhust2012
Copy link
Contributor

@carlvinhust2012 carlvinhust2012 commented Jan 6, 2023

Proposed changes

  1. this pr is used to adjust the vexpr for struct type when we import data.
  2. load the json as below to the table which include the struct column.
    { "id" : 0, "s1" : { "name": "jack", "age": 20 } }]

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Jan 6, 2023
@carlvinhust2012 carlvinhust2012 changed the title adjust the vexpr for struct type [feature](struct-type) adjust the vexpr for struct type Jan 6, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@carlvinhust2012 carlvinhust2012 force-pushed the struct-type-vexpr branch 4 times, most recently from 4b2d965 to 5a1d777 Compare January 12, 2023 07:58
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@carlvinhust2012 carlvinhust2012 force-pushed the struct-type-vexpr branch 2 times, most recently from 7c5972f to 90a3056 Compare January 12, 2023 08:09
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@carlvinhust2012 carlvinhust2012 force-pushed the struct-type-vexpr branch 3 times, most recently from 568cb3e to c1f748b Compare January 13, 2023 07:29
@carlvinhust2012 carlvinhust2012 force-pushed the struct-type-vexpr branch 2 times, most recently from 38e8e62 to b51db18 Compare January 13, 2023 08:02
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@carlvinhust2012 carlvinhust2012 force-pushed the struct-type-vexpr branch 2 times, most recently from 31c952d to c83fae7 Compare January 13, 2023 08:49
Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cambyzju cambyzju merged commit 7f4de92 into apache:struct-type Jan 13, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

3 similar comments
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants