Skip to content

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented Jan 13, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xy720 xy720 force-pushed the struct-type-hot-fix-2 branch from 4057be1 to 5ffaa29 Compare January 13, 2023 09:41
Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 13, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@cambyzju cambyzju merged commit 4ab8242 into apache:struct-type Jan 13, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xy720 added a commit to xy720/doris that referenced this pull request Jan 13, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xy720 xy720 self-assigned this Jan 17, 2023
xy720 added a commit that referenced this pull request Feb 6, 2023
xy720 added a commit that referenced this pull request Feb 6, 2023
xy720 added a commit that referenced this pull request Feb 9, 2023
xy720 added a commit that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/vectorization reviewed

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants