Support checking error data row when doing INSERT #1597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imay
requested changes
Aug 11, 2019
| // set to OK, which means the insert load job is successfully submitted. | ||
| // and user can check the job's status by label. | ||
| context.getState().setOk("{'label':'" + uuid.toString() + "'}"); | ||
| Map<String, String> res = Maps.newHashMap(); |
Contributor
There was a problem hiding this comment.
This can make some old client code not compatible. I think if client can get tracking URL from show load, we can not return URL here.
And this version is deprecated, I think it's better to keep old version's return
If INSERT operation failed on some error data rows, a url will be provided
for user to checking the error data rows.
eg:
{"label":"d2cac0a0-a16d-482d-9041-c949a4b71604","url":"xxx"}
or
ERROR 1064 (HY000): all partitions have no load data. url:xxx
morningman
force-pushed
the
insert_with_error_log
branch
from
d8df0d9 to
b707fc6
Compare
imay
reviewed
Aug 16, 2019
| return; | ||
| } | ||
|
|
||
| if (insertStmt.getQueryStmt() != null && (coord.getCommitInfos() == null || coord.getCommitInfos().isEmpty())) { |
Contributor
There was a problem hiding this comment.
we keep this when insertedRows and filterRows both are 0
imay
reviewed
Aug 16, 2019
| if (insertStmt.getQueryStmt() != null && (coord.getCommitInfos() == null || coord.getCommitInfos().isEmpty())) { | ||
| Catalog.getCurrentGlobalTransactionMgr().abortTransaction(insertStmt.getTransactionId(), "select stmt return empty set when insert"); | ||
| if (loadedRows == 0 && filteredRows == 0) { | ||
| // if no data, just return ok |
imay
approved these changes
Aug 16, 2019
Closed
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If strict mode is true, and at least one row is filtered, the insert operation will fail and a url will be given to get the error rows.
If all rows are good, insert will return OK with affected rows:
If strict mode is false, and at least one row is good, the insert operation will return OK with affected rows and warnings. If has error row num, a label will be returned: