Refactor alter job process #1613
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangkaisen
reviewed
Aug 8, 2019
| } | ||
|
|
||
| protected void runPendingJob() { | ||
| throw new NotImplementedException(); |
Contributor
There was a problem hiding this comment.
Making the AlterJobV2 to a abstract class is more reasonable？
Contributor
Author
There was a problem hiding this comment.
Yes, I will change it after all test are done
| // send all tasks and wait them finished | ||
| AgentTaskQueue.addBatchTask(batchTask); | ||
| AgentTaskExecutor.submit(batchTask); | ||
| // max timeout is 30 seconds |
Contributor
There was a problem hiding this comment.
30 seconds is certainly enough？ if the table has 1000 partitions and each partition has 100 buckets and only 10 BE.
Contributor
Author
There was a problem hiding this comment.
Maybe I should change it to a configuration. And default value is 30 sec.
Because I don't want to stuck in here for a long time if error happens. But for
the extreme case like you said, user can always modify the config to satisfy their case.
Contributor
There was a problem hiding this comment.
Yes. configuration is OK, like create table logic.
morningman
force-pushed
the
refactor_alter_job
branch
3 times, most recently
from
ec102bd to
609b0fa
Compare
morningman
force-pushed
the
refactor_alter_job
branch
from
572e44d to
cf70586
Compare
Merged
luwei16
added a commit
to luwei16/Doris
that referenced
this pull request
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE: #1429