Skip to content

Insert select Stmt keep the same semantics with mysql (#1626) #1628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imay merged 1 commit into from
Aug 13, 2019
Merged

Insert select Stmt keep the same semantics with mysql (#1626) #1628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions fe/src/main/java/org/apache/doris/qe/StmtExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,12 @@ private void handleInsertStmt() throws Exception {
return;
}

if (insertStmt.getQueryStmt() != null && (coord.getCommitInfos() == null || coord.getCommitInfos().isEmpty())) {
Copy link
Contributor

@imay imay Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we have already begin a transaction for this insert statement, if you return here now, it will become a pending transaction.
I think that you should abort this transaction before return to user

Copy link
Contributor Author

@wangbo wangbo Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌，I will check

Copy link
Contributor Author

@wangbo wangbo Aug 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we have already begin a transaction for this insert statement, if you return here now, it will become a pending transaction.
I think that you should abort this transaction before return to user

add abort operation;
sry ,I habitually performed a git rebase operation

Catalog.getCurrentGlobalTransactionMgr().abortTransaction(insertStmt.getTransactionId(), "select stmt return empty set when insert");
context.getState().setOk();
return;
}

Catalog.getCurrentGlobalTransactionMgr().commitAndPublishTransaction(
insertStmt.getDbObj(), insertStmt.getTransactionId(),
TabletCommitInfo.fromThrift(coord.getCommitInfos()),
Expand Down