Skip to content

[bugfix](topn) fix topn runtime predicate getting value bug for decimal type #16331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 2 commits into from
Feb 2, 2023
Merged

[bugfix](topn) fix topn runtime predicate getting value bug for decimal type #16331

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0873c85
fix topn runtime predicate getting value bug for decimal type
xiaokang Feb 1, 2023
cb05f67
fix cast_to_string bug for TYPE_DECIMALV2
xiaokang Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions be/src/runtime/runtime_predicate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,30 +147,31 @@ class RuntimePredicate {
}

static std::string get_decimalv2_value(const Field& field) {
using ValueType = typename PrimitiveTypeTraits<TYPE_DECIMALV2>::CppType;
ValueType value;
// can NOT use PrimitiveTypeTraits<TYPE_DECIMALV2>::CppType since
// it is DecimalV2Value and Decimal128 can not convert to it implicitly
using ValueType = Decimal128::NativeType;
auto v = field.get<DecimalField<Decimal128>>();
value.from_olap_decimal(v.get_value(), v.get_scale());
int scale = v.get_scale();
return cast_to_string<TYPE_DECIMALV2, ValueType>(value, scale);
// use TYPE_DECIMAL128I instead of TYPE_DECIMALV2 since v.get_scale()
// is always 9 for DECIMALV2
return cast_to_string<TYPE_DECIMAL128I, ValueType>(v.get_value(), v.get_scale());
}

static std::string get_decimal32_value(const Field& field) {
using ValueType = typename PrimitiveTypeTraits<TYPE_DECIMAL32>::CppType;
ValueType value = field.get<ValueType>();
return cast_to_string<TYPE_DECIMAL32, ValueType>(value, 0);
auto v = field.get<DecimalField<Decimal32>>();
return cast_to_string<TYPE_DECIMAL32, ValueType>(v.get_value(), v.get_scale());
}

static std::string get_decimal64_value(const Field& field) {
using ValueType = typename PrimitiveTypeTraits<TYPE_DECIMAL64>::CppType;
ValueType value = field.get<ValueType>();
return cast_to_string<TYPE_DECIMAL64, ValueType>(value, 0);
auto v = field.get<DecimalField<Decimal64>>();
return cast_to_string<TYPE_DECIMAL64, ValueType>(v.get_value(), v.get_scale());
}

static std::string get_decimal128_value(const Field& field) {
using ValueType = typename PrimitiveTypeTraits<TYPE_DECIMAL128I>::CppType;
ValueType value = field.get<ValueType>();
return cast_to_string<TYPE_DECIMAL128I, ValueType>(value, 0);
auto v = field.get<DecimalField<Decimal128I>>();
return cast_to_string<TYPE_DECIMAL128I, ValueType>(v.get_value(), v.get_scale());
}
};

Expand Down