Skip to content

improve logic to sending to broker #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lingbin merged 1 commit into from
Dec 27, 2017
Merged

improve logic to sending to broker #166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions be/src/exec/broker_writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,26 +139,31 @@ Status BrokerWriter::write(const uint8_t* buf, size_t buf_len, size_t* written_l
TBrokerOperationStatus response;
try {
Status status;
// 500ms is enough
BrokerServiceConnection client(client_cache(_state), broker_addr, 500, &status);
// we make timeout to be 5s, to avoid error in Network jitter scenarios.
BrokerServiceConnection client(client_cache(_state), broker_addr, 5000, &status);
if (!status.ok()) {
LOG(WARNING) << "Create broker write client failed. "
<< "broker=" << broker_addr
<< ", status=" << status.get_error_msg();
return status;
}

// we do not re-try simplely, because broker server may already write data
try {
client->pwrite(response, request);
} catch (apache::thrift::transport::TTransportException& e) {
RETURN_IF_ERROR(client.reopen());
client->pwrite(response, request);

std::stringstream ss;
ss << "Fail to write to broker, broker:" << broker_addr << " failed:" << e.what();
LOG(WARNING) << ss.str();
return Status(TStatusCode::THRIFT_RPC_ERROR, ss.str());
}
} catch (apache::thrift::TException& e) {
std::stringstream ss;
ss << "Fail to write to broker, broker:" << broker_addr << " failed:" << e.what();
LOG(WARNING) << ss.str();
return Status(TStatusCode::THRIFT_RPC_ERROR, ss.str(), false);
return Status(TStatusCode::THRIFT_RPC_ERROR, ss.str());
}

VLOG_ROW << "debug: send broker pwrite response: "
Expand Down