Skip to content

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented Feb 10, 2023

Proposed changes

Issue Number: close #16547

Problem summary

For example, currently not support insert {1, 'a'} into struct<f1:tinyint, f2:varchar(20)>
This commit will support implicitly cast the char type in the struct to varchar.

Add implicitly cast for struct-type.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xy720 xy720 added the struct-type Issues or PRs related to struct type label Feb 10, 2023
@xy720 xy720 force-pushed the support-implicitly-cast-struct branch from f34004a to 8ef92e7 Compare February 10, 2023 11:48
@hello-stephen
Copy link
Contributor

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.5 seconds
stream load tsv: 487 seconds loaded 74807831229 Bytes, about 146 MB/s
stream load json: 36 seconds loaded 2358488459 Bytes, about 62 MB/s
stream load orc: 69 seconds loaded 1101869774 Bytes, about 15 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230210174104_clickbench_pr_94167.html

Copy link
Contributor

@cambyzju cambyzju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 15, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xy720 xy720 merged commit 0c56a46 into apache:master Feb 15, 2023
@xy720 xy720 mentioned this pull request Feb 24, 2023
88 tasks
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
)

Currently not support insert {1, 'a'} into struct<f1:tinyint, f2:varchar(20)>
This commit will support implicitly cast the char type in the struct to varchar.
Add implicitly cast for struct-type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/test reviewed struct-type Issues or PRs related to struct type

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Roadmap] Support Struct+Map Type

3 participants