Skip to content

Conversation

@worker24h
Copy link
Contributor

No description provided.

Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// for create tablet and restore
public Replica(long replicaId, long backendId, ReplicaState state, long version, long versionHash, int schemaHash) {
this(replicaId, backendId, version, versionHash, schemaHash, -1, -1, state, -1L, 0L, version, versionHash);
this(replicaId, backendId, version, versionHash, schemaHash, 0L, -1, state, -1L, 0L, version, versionHash);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this(replicaId, backendId, version, versionHash, schemaHash, 0L, -1, state, -1L, 0L, version, versionHash);
this(replicaId, backendId, version, versionHash, schemaHash, 0L, 0L, state, -1L, 0L, version, versionHash);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@imay imay merged commit 9f50f84 into apache:master Aug 21, 2019
@imay imay mentioned this pull request Sep 26, 2019
swjtu-zhanglei pushed a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants