Skip to content

Add a loaded rows in SHOW LOAD result #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
imay merged 8 commits into from
Aug 27, 2019
Merged

Add a loaded rows in SHOW LOAD result #1686

imay merged 8 commits into from
Aug 27, 2019

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Aug 21, 2019 •
edited
Loading

Add a new column 'JobDetails' to show more info of a load job.
Loaded rows will be updated periodically by query report. So that
user can see that a load job is still running or being blocked.

eg:

         JobId: 12010
         Label: fact_20190811_0000
         State: LOADING
      Progress: ETL:N/A; LOAD:0%
          Type: BROKER
       EtlInfo: N/A
      TaskInfo: cluster:N/A; timeout(s):36000; max_filter_ratio:0.01
      ErrorMsg: N/A
    CreateTime: 2019-08-21 23:38:40
  EtlStartTime: 2019-08-21 23:38:41
 EtlFinishTime: 2019-08-21 23:38:41
 LoadStartTime: 2019-08-21 23:38:41
LoadFinishTime: N/A
           URL: N/A
    JobDetails: {"LoadedRows":1875968,"TaskNumber":1,"FileNumber":1,"FileSize":940754064}

@morningman
Add a loaded rows in SHOW LOAD result
01203de 
Loaded rows will be updated periodically by query report. So that
user can see that a load job is still running or being blocked.
@morningman
fix bug
e86bec9
@morningman
add doc
22e0b5f
@morningman
fix bug
fcce975
@morningman
add job details
e1d0083
@morningman
add doc
84bece7
imay
imay requested changes Aug 22, 2019
View reviewed changes
fe/src/main/java/org/apache/doris/load/loadv2/LoadJob.java Outdated

// number of rows processed on BE, this number will be updated periodically by query report.
// A load job may has several load tasks, so the map key is load task's plan load id.
protected Map<TUniqueId, AtomicLong> numLoadedRows = Maps.newConcurrentMap();
Copy link
Contributor

@imay imay Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to make RuntimeStatics, not only numLoadedRows.
And it name should be xxxMap.

Copy link
Contributor Author

@morningman morningman Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

chaoyli
chaoyli previously approved these changes Aug 22, 2019
View reviewed changes
@morningman morningman closed this Aug 26, 2019
@morningman morningman reopened this Aug 26, 2019
imay
imay approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit a1b9276 into apache:master Aug 27, 2019
@imay imay mentioned this pull request Sep 26, 2019
Closed
swjtu-zhanglei pushed a commit to swjtu-zhanglei/incubator-doris that referenced this pull request Jul 25, 2023
@deardeng
(selectdb-cloud) Fix regression case test_cluster and test_instance (a…
e2b6e11 
…pache#1686)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imay imay imay approved these changes

@chaoyli chaoyli chaoyli left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@morningman @imay @chaoyli