Skip to content

[bugfix](topn) fix topn read_orderby_key_columns nullptr #16896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 3 commits into from
Feb 19, 2023
Merged

[bugfix](topn) fix topn read_orderby_key_columns nullptr #16896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2199525
fix topn read_orderby_key_columns nullptr
xiaokang Feb 18, 2023
c2d291f
fix INTERNAL_ERROR
xiaokang Feb 18, 2023
67d710a
clang format
xiaokang Feb 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions be/src/olap/reader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,10 +412,6 @@ Status TabletReader::_init_keys_param(const ReaderParams& read_params) {
}

Status TabletReader::_init_orderby_keys_param(const ReaderParams& read_params) {
if (read_params.start_key.empty()) {
return Status::OK();
}

// UNIQUE_KEYS will compare all keys as before
if (_tablet_schema->keys_type() == DUP_KEYS || (_tablet_schema->keys_type() == UNIQUE_KEYS &&
_tablet->enable_unique_key_merge_on_write())) {
Expand Down
5 changes: 5 additions & 0 deletions be/src/vec/olap/vcollect_iterator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,11 @@ Status VCollectIterator::_topn_next(Block* block) {
auto cloneBlock = block->clone_empty();
MutableBlock mutable_block = vectorized::MutableBlock::build_mutable_block(&cloneBlock);

if (!_reader->_reader_context.read_orderby_key_columns) {
return Status::Error<ErrorCode::INTERNAL_ERROR>(
"read_orderby_key_columns should not be nullptr");
}

size_t first_sort_column_idx = (*_reader->_reader_context.read_orderby_key_columns)[0];
const std::vector<uint32_t>* sort_columns = _reader->_reader_context.read_orderby_key_columns;

Expand Down