Skip to content

Conversation

@xiaokang
Copy link
Contributor

@xiaokang xiaokang commented Feb 19, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

basic functions for map datatype:

  • MAP<K, V> map(K k1, V v1, ...)
  • BIGINT map_size(MAP<K, V> m)
  • BOOL map_contains_key(MAP<K, V> m, K k1)
  • BOOL map_contains_value(MAP<K, V> m, V v1)
  • ARRAY< K> map_keys(MAP<K, V> m)
  • ARRAY< V> map_values(MAP<K, V> m)

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/test labels Feb 19, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@zhangguoqiang666
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang xiaokang force-pushed the map_functions_basic branch from 78158c9 to 2863167 Compare February 24, 2023 09:55
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang
Copy link
Contributor Author

run buildall

@xiaokang xiaokang force-pushed the map_functions_basic branch from 2863167 to 67a0105 Compare February 24, 2023 13:30
@xiaokang
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang
Copy link
Contributor Author

run buildall

@xiaokang xiaokang force-pushed the map_functions_basic branch from 67a0105 to 540207d Compare March 8, 2023 17:43
@xiaokang
Copy link
Contributor Author

xiaokang commented Mar 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang xiaokang force-pushed the map_functions_basic branch from 540207d to cccfdcd Compare March 9, 2023 02:33
@xiaokang
Copy link
Contributor Author

xiaokang commented Mar 9, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang xiaokang force-pushed the map_functions_basic branch from cccfdcd to e9a1136 Compare March 9, 2023 08:56
@xiaokang
Copy link
Contributor Author

xiaokang commented Mar 9, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

@xiaokang
Copy link
Contributor Author

run beut

@xiaokang xiaokang force-pushed the map_functions_basic branch from 7a450b1 to e0d3e77 Compare March 11, 2023 15:15
@xiaokang
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xy720
xy720 previously approved these changes Mar 14, 2023
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but need rebase master

@amorynan
Copy link
Contributor

LGTM

@xiaokang xiaokang force-pushed the map_functions_basic branch from e0d3e77 to 810e615 Compare March 14, 2023 05:11
@xiaokang
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xy720
xy720 previously approved these changes Mar 14, 2023
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 14, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xiaokang
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 15, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xy720 xy720 merged commit 5d3de05 into apache:master Mar 17, 2023
@xy720 xy720 mentioned this pull request Mar 28, 2023
88 tasks
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
basic functions for map datatype:
- MAP<K, V> map(K k1, V v1, ...)
- BIGINT map_size(MAP<K, V> m)
- BOOL map_contains_key(MAP<K, V> m, K k1)
- BOOL map_contains_value(MAP<K, V> m, V v1)
- ARRAY< K> map_keys(MAP<K, V> m)
- ARRAY< V> map_values(MAP<K, V> m)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/test reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants