Skip to content

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Feb 20, 2023

Proposed changes

add contains_null for map

#16547

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner area/vectorization labels Feb 20, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the area/sql/function Issues or PRs related to the SQL functions label Feb 21, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

xy720
xy720 previously approved these changes Feb 21, 2023
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 21, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@amorynan
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 22, 2023
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

run buildall

@amorynan
Copy link
Contributor Author

run compile

@amorynan
Copy link
Contributor Author

run p0

1 similar comment
@amorynan
Copy link
Contributor Author

run p0

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@amorynan
Copy link
Contributor Author

run p0

@amorynan
Copy link
Contributor Author

run buildall

@xy720 xy720 added the map-type Issues or PRs related to map type label Feb 23, 2023
@amorynan
Copy link
Contributor Author

run compile

Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy720 xy720 merged commit 7229751 into apache:master Feb 23, 2023
@xy720 xy720 mentioned this pull request Feb 24, 2023
88 tasks
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/planner Issues or PRs related to the query planner area/sql/function Issues or PRs related to the SQL functions area/vectorization map-type Issues or PRs related to map type reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants