-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Bug](complex-type) Fix is null predicate in delete stmt for array/struct/map type #17018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
cambyzju
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run buildall |
|
run p0 |
1 similar comment
|
run p0 |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
run p0 |
cambyzju
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
This commit fix two problems:
1、fix insert null for struct-type
how to reproduce:
The correct result should be:
2、fix is null predicate in delete stmt for array
how to reproduce:
There are same problems in struct and map type.
The core dump is like:
The reason is that the predicate column should be a child in array/struct/map column.
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...