Skip to content

[fix](struct-type) fix struct subtype support #17081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xy720 merged 2 commits into from
Feb 28, 2023
Merged

[fix](struct-type) fix struct subtype support #17081

xy720 merged 2 commits into from
Feb 28, 2023

Conversation

@cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Feb 23, 2023 •
edited by xy720
Loading

Proposed changes

Issue Number: close #16547

Problem summary

  1. Make sure all sub types which STRUCT supported work correctly;
  2. remove unused variable _need_validate_data;
  3. lazy init min or max decimal to support nested DecimalV2 column validate;

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/planner Issues or PRs related to the query planner area/vectorization kind/test labels Feb 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju
Copy link
Contributor Author

cambyzju commented Feb 23, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

clang-tidy review says "All clean, LGTM! 👍"

@hello-stephen
Copy link
Contributor

hello-stephen commented Feb 23, 2023 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.34 seconds
stream load tsv: 489 seconds loaded 74807831229 Bytes, about 145 MB/s
stream load json: 40 seconds loaded 2358488459 Bytes, about 56 MB/s
stream load orc: 80 seconds loaded 1101869774 Bytes, about 13 MB/s
stream load parquet: 29 seconds loaded 861443392 Bytes, about 28 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230227145450_clickbench_pr_105188.html

@cambyzju
Copy link
Contributor Author

cambyzju commented Feb 23, 2023

run feut

xy720
xy720 previously approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xy720
Copy link
Member

xy720 commented Feb 23, 2023

run p0

@xy720
Copy link
Member

xy720 commented Feb 23, 2023

run feut

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 23, 2023

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Feb 24, 2023
@cambyzju
Copy link
Contributor Author

cambyzju commented Feb 24, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju
Copy link
Contributor Author

cambyzju commented Feb 24, 2023

run feut

@cambyzju
Copy link
Contributor Author

cambyzju commented Feb 24, 2023

run p0

@xy720 xy720 mentioned this pull request Feb 24, 2023
Closed
88 tasks
@cambyzju
Copy link
Contributor Author

cambyzju commented Feb 24, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 24, 2023

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju
Copy link
Contributor Author

cambyzju commented Feb 26, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 26, 2023

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju
Copy link
Contributor Author

cambyzju commented Feb 26, 2023

run p0

1 similar comment
@cambyzju
Copy link
Contributor Author

cambyzju commented Feb 27, 2023

run p0

@cambyzju
Copy link
Contributor Author

cambyzju commented Feb 27, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2023

clang-tidy review says "All clean, LGTM! 👍"

xy720
xy720 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Feb 28, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

PR approved by at least one committer and no changes requested.

@xy720 xy720 merged commit 4d8b310 into apache:master Feb 28, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 9, 2023
@cambyzju @yagagagaga
[fix](struct-type) fix struct subtype support (apache#17081)
35440f5 
1. Make sure all sub types which STRUCT supported work correctly;
2. remove unused variable `_need_validate_data`;
3. lazy init min or max decimal to support nested DecimalV2 column validate;

Co-authored-by: cambyzju <zhuxiaoli01@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xy720 xy720 xy720 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/planner Issues or PRs related to the query planner area/vectorization kind/test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Roadmap] Support Struct+Map Type

3 participants

@cambyzju @hello-stephen @xy720