Skip to content

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Aug 27, 2019

Add a new FE config 'max_distribution_pruner_recursion_depth'.
Also fix pruning depth calculation bug.

Add a new FE config 'max_distribution_pruner_recursion_depth'.
private List<Long> bucketsList;
// partition columns
private List<Column> partitionColumns;
private List<Column> distributionColumns;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep one space

}
InPredicate inPredicate = filter.getInPredicate();
if (null == inPredicate || inPredicate.getChildren().size() * complex > 100) {
if (null == inPredicate || inPredicate.getChildren().size() * complex > Config.max_distribution_pruner_recursion_depth) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

children().size() - 1

Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit b6b860c into apache:master Aug 27, 2019
@imay imay mentioned this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants