-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Chore](third-party) upgrade thrift from 0.13 to 0.16 #17202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
is it compatible with old thrift version 0.13? better test it |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run p0 |
|
run feut |
|
run compile |
|
run feut |
|
run p0 |
1 similar comment
|
run p0 |
|
run buildall |
1 similar comment
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run feut |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run feut |
|
run compile |
|
run p0 |
|
run arm |
|
run p0 |
|
run arm |
|
run p0 |
1 similar comment
|
run p0 |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
update update update update fix fix fix fix fix
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
It looks like |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
This reverts commit 1a549ed.
upgrade thrift from 0.13 to 0.16 There is thrift's release notes https://github.com/apache/thrift/blob/master/CHANGES.md
Proposed changes
I found that
thriftoften has some crash underasan, I want to try to upgrade it to the latest version and see if the problem still occurs.There is thrift's release notes https://github.com/apache/thrift/blob/master/CHANGES.md
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...