Skip to content

[enhancement](merge-on-write) change cu compaction correctness check to warning #17250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhannngchen wants to merge 2 commits into from
Closed

[enhancement](merge-on-write) change cu compaction correctness check to warning #17250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3725081
change cu compaction correctness check to warning
zhannngchen Feb 28, 2023
e677ecd
update
zhannngchen Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions be/src/olap/compaction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,11 +434,13 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) {
RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map));

if (compaction_type() == READER_CUMULATIVE_COMPACTION) {
std::string err_msg =
"The merged rows is not equal to missed rows in rowid conversion";
DCHECK(stats != nullptr || stats->merged_rows == missed_rows) << err_msg;
std::string err_msg = fmt::format(
"cumulative compaction: the merged rows({}) is not equal to missed "
"rows({}) in rowid conversion, tablet_id: {}, table_id:{}",
stats->merged_rows, missed_rows, _tablet->tablet_id(), _tablet->table_id());
DCHECK(stats == nullptr || stats->merged_rows == missed_rows) << err_msg;
if (stats != nullptr && stats->merged_rows != missed_rows) {
return Status::InternalError(err_msg);
LOG(WARNING) << err_msg;
}
}

Expand Down