Error check about column which has no default value #1728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit check the all of parsed column include hadoop function and other function. Otherwise, the load will thrown the "Column has no default value" exception while the column also has been defined by a non-hadoop function.
morningman
approved these changes
Aug 30, 2019
| } | ||
| } | ||
|
|
||
| // check hll |
Contributor
There was a problem hiding this comment.
hll_hash is a kind of hadoop function, so here we use columnToHadoopFunction to check only HLL column is correct.
imay
approved these changes
Aug 30, 2019
Closed
chaoyli
added a commit
to chaoyli/incubator-doris
that referenced
this pull request
Jan 28, 2021
…fault value. (apache#1728) One Tablet have three replicas, the compaction progress is different. Considering the following scenario, replica A have 3 versions(1, 2, 3); replica B have 2 versions(1-2, 3); replicat C have 1 versions(1-3). Now a column named city been added with default zero 1. Replica A will be resulted as 3, replica B results as 2, replica C results as 1. So there is a necessity to restrict the default value to zero for SUM aggreagation column.
swjtu-zhanglei
pushed a commit
to swjtu-zhanglei/incubator-doris
that referenced
this pull request
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit check the all of parsed columns include hadoop functions and other functions.
Otherwise, the load will thrown the "Column has no default value" exception while the column also has been defined by a non-hadoop function.