-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feature](function) support type template in SQL function #17344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
be08682
init commit for function template
xiaokang f9870a4
first working version
xiaokang 56e6496
fix whitespace problem in template function
xiaokang 5621e96
make tempalte function specialize and match more robust
xiaokang 47b521e
delete useless code
xiaokang 2a4be8d
fix checkstyle
xiaokang 85422d5
add map[key] testcase for multi map kv types
xiaokang 0153e15
fix ArrayType specializeTemplateType
xiaokang bc4d8c0
add doc in builtins_functions.py
xiaokang 4634de0
fix comment
xiaokang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
132 changes: 132 additions & 0 deletions
132
fe/fe-common/src/main/java/org/apache/doris/catalog/TemplateType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,132 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| package org.apache.doris.catalog; | ||
|
|
||
| import org.apache.doris.thrift.TColumnType; | ||
| import org.apache.doris.thrift.TTypeDesc; | ||
|
|
||
| import com.google.common.base.Strings; | ||
| import com.google.gson.annotations.SerializedName; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * Describes a TemplateType type, used for SQL function argument and return type, | ||
| * NOT used for table column type. | ||
| */ | ||
| public class TemplateType extends Type { | ||
|
|
||
| @SerializedName(value = "name") | ||
| private final String name; | ||
|
|
||
| public TemplateType(String name) { | ||
| this.name = name; | ||
| } | ||
|
|
||
| @Override | ||
| public PrimitiveType getPrimitiveType() { | ||
| return PrimitiveType.TEMPLATE; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object other) { | ||
| if (!(other instanceof TemplateType)) { | ||
| return false; | ||
| } | ||
| TemplateType o = (TemplateType) other; | ||
| return o.name.equals(name); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean matchesType(Type t) { | ||
| // not matches any type | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean hasTemplateType() { | ||
| return true; | ||
| } | ||
|
|
||
| @Override | ||
| public Type specializeTemplateType(Type specificType, Map<String, Type> specializedTypeMap, | ||
| boolean useSpecializedType) throws TypeException { | ||
| if (specificType.hasTemplateType() && !specificType.isNull()) { | ||
| throw new TypeException(specificType + " should not hasTemplateType"); | ||
| } | ||
|
|
||
| Type specializedType = specializedTypeMap.get(name); | ||
| if (useSpecializedType) { | ||
| if (specializedType == null) { | ||
| throw new TypeException("template type " + name + " is not specialized yet"); | ||
| } | ||
| return specializedType; | ||
| } | ||
|
|
||
| if (specializedType != null | ||
| && !specificType.equals(specializedType) | ||
| && !specificType.matchesType(specializedType) | ||
| && !Type.isImplicitlyCastable(specificType, specializedType, true) | ||
| && !Type.canCastTo(specificType, specializedType)) { | ||
| throw new TypeException( | ||
| String.format("can not specialize template type %s to %s since it's already specialized as %s", | ||
| name, specificType, specializedType)); | ||
| } | ||
|
|
||
| if (specializedType == null) { | ||
| specializedTypeMap.put(name, specificType); | ||
| } | ||
| return specializedTypeMap.get(name); | ||
| } | ||
|
|
||
| @Override | ||
| public String toSql(int depth) { | ||
| return name; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return toSql(0).toUpperCase(); | ||
| } | ||
|
|
||
| @Override | ||
| protected String prettyPrint(int lpad) { | ||
| String leftPadding = Strings.repeat(" ", lpad); | ||
| return leftPadding + toSql(); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean supportSubType(Type subType) { | ||
| throw new RuntimeException("supportSubType not implementd for TemplateType"); | ||
| } | ||
|
|
||
| @Override | ||
| public void toThrift(TTypeDesc container) { | ||
| throw new RuntimeException("can not call toThrift on TemplateType"); | ||
| } | ||
|
|
||
| @Override | ||
| public TColumnType toColumnTypeThrift() { | ||
| throw new RuntimeException("can not call toColumnTypeThrift on TemplateType"); | ||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() { | ||
| return name.hashCode(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussion, when specializedType != null
specializedTypeMap should store the CompatibleType of specificType and specializedType.
You can use
Type.getAssignmentCompatibleTypemethod.