Skip to content

[fix](segcompaction) core when doing segcompaction for cancelling load(#16731) #17432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Mar 5, 2023
Merged

[fix](segcompaction) core when doing segcompaction for cancelling load(#16731) #17432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion be/src/olap/rowset/beta_rowset_writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,11 @@ BetaRowsetWriter::BetaRowsetWriter()
}

BetaRowsetWriter::~BetaRowsetWriter() {
// OLAP_UNUSED_ARG(_wait_flying_segcompaction());
/* Note that segcompaction is async and in parallel with load job. So we should handle carefully
* when the job is cancelled. Although it is meaningless to continue segcompaction when the job
* is cancelled, the objects involved in the job should be preserved during segcompaction to
* avoid crashs for memory issues. */
OLAP_UNUSED_ARG(_wait_flying_segcompaction());

// TODO(lingbin): Should wrapper exception logic, no need to know file ops directly.
if (!_already_built) { // abnormal exit, remove all files generated
Expand Down