Skip to content

[fix](segcompaction) heap overflow when doing segcompaction for cance… #17529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhannngchen merged 1 commit into from
Mar 10, 2023
Merged

[fix](segcompaction) heap overflow when doing segcompaction for cance… #17529

zhannngchen merged 1 commit into from
Mar 10, 2023

Conversation

@freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Mar 7, 2023

…lling load(#16731)

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

clang-tidy review says "All clean, LGTM! 👍"

@freemandealer
Copy link
Contributor Author

freemandealer commented Mar 7, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 7, 2023 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.16 seconds
stream load tsv: 458 seconds loaded 74807831229 Bytes, about 155 MB/s
stream load json: 40 seconds loaded 2358488459 Bytes, about 56 MB/s
stream load orc: 73 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230308052221_clickbench_pr_110566.html

@morningman morningman added usercase Important user case type label dev/1.2.3 labels Mar 8, 2023
@freemandealer
[fix](segcompaction) heap overflow when doing segcompaction for cance…
4d30414 
…lling load(apache#16731)

Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
@freemandealer freemandealer force-pushed the fix-segcompaction-write-page-core branch from 5b28a8a to 4d30414 Compare March 8, 2023 02:50
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@freemandealer
Copy link
Contributor Author

freemandealer commented Mar 8, 2023

run buildall

@freemandealer
Copy link
Contributor Author

freemandealer commented Mar 8, 2023

run clickbench

dataroaring
dataroaring approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

PR approved by anyone and no changes requested.

@freemandealer
Copy link
Contributor Author

freemandealer commented Mar 8, 2023

run p0

zhannngchen
zhannngchen approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen zhannngchen merged commit 2739a44 into apache:master Mar 10, 2023
@yiguolei yiguolei removed usercase Important user case type label dev/1.2.3 labels Apr 4, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@freemandealer @gnehil
[fix](segcompaction) heap overflow when doing segcompaction for cance…
8878f53 
…lling load(apache#17529)

Signed-off-by: freemandealer <freeman.zhang1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. need-cherry-pick reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@freemandealer @hello-stephen @zhannngchen @dataroaring @morningman @yiguolei