[feature](struct-type) support CAST AS Struct type #17553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

xy720 merged 5 commits into apache:master from cambyzju:struct-0308

Mar 10, 2023

Contributor

cambyzju commented Mar 8, 2023 •

edited

Loading

Proposed changes

Issue Number: close #16547

Problem summary

add support CAST AS Struct from Struct type;
fix crash while CAST('{}' AS Struct);
CAST('' AS complext_type) should return NULL instead of empty object;

Checklist(Required)

Does it affect the original behavior
Has unit tests been added
Has document been added or modified
Does it need to update dependencies
Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...


          fix insert empty struct

68a4c93

github-actions bot added the area/vectorization label

Contributor

github-actions bot commented Mar 8, 2023

clang-tidy review says "All clean, LGTM! 👍"


          only support cast string to struct type

a0d6aaf

github-actions bot added the area/sql/function label

Contributor

github-actions bot commented Mar 8, 2023

clang-tidy review says "All clean, LGTM! 👍"


          support CAST AS Struct from struct type

e48f112

Contributor

github-actions bot commented Mar 9, 2023

clang-tidy review says "All clean, LGTM! 👍"


          fix cast empty string to complex type

dd3db22

cambyzju changed the title ~~[fix](struct-type) support string cast to struct-type~~ [fix](struct-type) support CAST AS Struct type

Contributor

github-actions bot commented Mar 9, 2023

clang-tidy review says "All clean, LGTM! 👍"


          add regression test

b0efc64

github-actions bot added the kind/test label

Contributor Author

cambyzju commented Mar 9, 2023

run buildall

Contributor

github-actions bot commented Mar 9, 2023

clang-tidy review says "All clean, LGTM! 👍"

Contributor

hello-stephen commented Mar 9, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.36 seconds
stream load tsv: 458 seconds loaded 74807831229 Bytes, about 155 MB/s
stream load json: 39 seconds loaded 2358488459 Bytes, about 57 MB/s
stream load orc: 74 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230309100052_clickbench_pr_111350.html

cambyzju changed the title ~~[fix](struct-type) support CAST AS Struct type~~ [feature](struct-type) support CAST AS Struct type

xy720 approved these changes

View reviewed changes

Member

xy720 left a comment

LGTM

xy720 merged commit 6dcd791 into apache:master

github-actions bot added the approved label

Contributor

github-actions bot commented Mar 10, 2023

PR approved by at least one committer and no changes requested.

github-actions bot added the reviewed label

Contributor

github-actions bot commented Mar 10, 2023

PR approved by anyone and no changes requested.

xy720 mentioned this pull request

[Roadmap] Support Struct+Map Type #16547

Closed

88 tasks

gnehil pushed a commit to gnehil/doris that referenced this pull request


          [feature](struct-type) support CAST AS Struct type (apache#17553)

23abb73

1. add support `CAST AS Struct` from Struct type;
2. fix crash while `CAST('{}' AS Struct)`;
3. `CAST('' AS complext_type)` should return NULL instead of empty object;

---------

Co-authored-by: cambyzju <zhuxiaoli01@baidu.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/sql/function area/vectorization kind/test reviewed