Encapsulate HLL logic #1756
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,10 +65,4 @@ add_library(Exprs | |
| agg_fn.cc | ||
| new_agg_fn_evaluator.cc | ||
| bitmap_function.cpp | ||
| hll_function.cpp) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #include "exprs/hll_function.h" | ||
|
|
||
| #include "exprs/anyval_util.h" | ||
| #include "util/hash_util.hpp" | ||
|
|
||
| namespace doris { | ||
|
|
||
| using doris_udf::BigIntVal; | ||
| using doris_udf::StringVal; | ||
|
|
||
| void HllFunctions::init() { | ||
| } | ||
|
|
||
| StringVal HllFunctions::hll_hash(FunctionContext* ctx, const StringVal& input) { | ||
| const int HLL_SINGLE_VALUE_SIZE = 10; | ||
| const int HLL_EMPTY_SIZE = 1; | ||
| std::string buf; | ||
| std::unique_ptr<HyperLogLog> hll; | ||
| if (!input.is_null) { | ||
| uint64_t hash_value = HashUtil::murmur_hash64A(input.ptr, input.len, HashUtil::MURMUR_SEED); | ||
| hll.reset(new HyperLogLog(hash_value)); | ||
|
Contributor
There was a problem hiding this comment. For this case we create HyperLogLog two times |
||
| buf.resize(HLL_SINGLE_VALUE_SIZE); | ||
| } else { | ||
| hll.reset(new HyperLogLog()); | ||
| buf.resize(HLL_EMPTY_SIZE); | ||
| } | ||
| hll->serialize((char*)buf.c_str()); | ||
|
Contributor
There was a problem hiding this comment. why not serialize(std::string*) ?
Contributor
Author
There was a problem hiding this comment. Because slice.data type is char* and many HLL methods use char*. |
||
| return AnyValUtil::from_string_temp(ctx, buf); | ||
| } | ||
|
|
||
| void HllFunctions::hll_init(FunctionContext *, StringVal* dst) { | ||
| dst->is_null = false; | ||
| dst->len = sizeof(HyperLogLog); | ||
| dst->ptr = (uint8_t*)new HyperLogLog(); | ||
| } | ||
|
|
||
| template <typename T> | ||
| void HllFunctions::hll_update(FunctionContext *, const T &src, StringVal* dst) { | ||
| if (src.is_null) { | ||
| return; | ||
| } | ||
|
|
||
| uint64_t hash_value = AnyValUtil::hash64_murmur(src, HashUtil::MURMUR_SEED); | ||
| if (hash_value != 0) { | ||
| auto* dst_hll = reinterpret_cast<HyperLogLog*>(dst->ptr); | ||
| dst_hll->update(hash_value); | ||
| } | ||
| } | ||
| void HllFunctions::hll_merge(FunctionContext*, const StringVal &src, StringVal* dst) { | ||
| HyperLogLog src_hll = HyperLogLog((char*)src.ptr); | ||
| auto* dst_hll = reinterpret_cast<HyperLogLog*>(dst->ptr); | ||
| dst_hll->merge(src_hll); | ||
| } | ||
|
|
||
| BigIntVal HllFunctions::hll_finalize(FunctionContext*, const StringVal &src) { | ||
| auto* src_hll = reinterpret_cast<HyperLogLog*>(src.ptr); | ||
| BigIntVal result(src_hll->estimate_cardinality()); | ||
| delete src_hll; | ||
| return result; | ||
| } | ||
|
|
||
| BigIntVal HllFunctions::hll_cardinality(FunctionContext* ctx, const StringVal& input) { | ||
| if (input.is_null) { | ||
| return BigIntVal::null(); | ||
| } | ||
| StringVal dst; | ||
| hll_init(ctx, &dst); | ||
| hll_merge(ctx, input, &dst); | ||
| return hll_finalize(ctx, dst); | ||
| } | ||
|
|
||
| StringVal HllFunctions::hll_serialize(FunctionContext *ctx, const StringVal &src) { | ||
| auto* src_hll = reinterpret_cast<HyperLogLog*>(src.ptr); | ||
| StringVal result(ctx, HLL_COLUMN_DEFAULT_LEN); | ||
| int size = src_hll->serialize((char*)result.ptr); | ||
| result.resize(ctx, size); | ||
| delete src_hll; | ||
| return result; | ||
| } | ||
|
|
||
| template void HllFunctions::hll_update(FunctionContext*, const BooleanVal&, StringVal*); | ||
| template void HllFunctions::hll_update(FunctionContext*, const TinyIntVal&, StringVal*); | ||
| template void HllFunctions::hll_update(FunctionContext*, const SmallIntVal&, StringVal*); | ||
| template void HllFunctions::hll_update(FunctionContext*, const IntVal&, StringVal*); | ||
| template void HllFunctions::hll_update(FunctionContext*, const BigIntVal&, StringVal*); | ||
| template void HllFunctions::hll_update(FunctionContext*, const FloatVal&, StringVal*); | ||
| template void HllFunctions::hll_update(FunctionContext*, const DoubleVal&, StringVal*); | ||
| template void HllFunctions::hll_update(FunctionContext*, const StringVal&, StringVal*); | ||
| template void HllFunctions::hll_update(FunctionContext*, const DateTimeVal&, StringVal*); | ||
| template void HllFunctions::hll_update(FunctionContext*, const LargeIntVal&, StringVal*); | ||
| template void HllFunctions::hll_update(FunctionContext*, const DecimalVal&, StringVal*); | ||
| template void HllFunctions::hll_update(FunctionContext*, const DecimalV2Val&, StringVal*); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| // Licensed to the Apache Software Foundation (ASF) under one | ||
| // or more contributor license agreements. See the NOTICE file | ||
| // distributed with this work for additional information | ||
| // regarding copyright ownership. The ASF licenses this file | ||
| // to you under the Apache License, Version 2.0 (the | ||
| // "License"); you may not use this file except in compliance | ||
| // with the License. You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, | ||
| // software distributed under the License is distributed on an | ||
| // "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| // KIND, either express or implied. See the License for the | ||
| // specific language governing permissions and limitations | ||
| // under the License. | ||
|
|
||
| #ifndef DORIS_BE_SRC_QUERY_EXPRS_HLL_FUNCTION_H | ||
| #define DORIS_BE_SRC_QUERY_EXPRS_HLL_FUNCTION_H | ||
|
|
||
| #include "udf/udf.h" | ||
|
|
||
| namespace doris { | ||
|
|
||
| class HllFunctions { | ||
| public: | ||
| static void init(); | ||
| static StringVal hll_hash(FunctionContext* ctx, const StringVal& dest_base); | ||
| static void hll_init(FunctionContext*, StringVal* dst); | ||
|
|
||
| template <typename T> | ||
| static void hll_update(FunctionContext*, const T& src, StringVal* dst); | ||
|
|
||
| static void hll_merge(FunctionContext*,const StringVal& src, StringVal* dst); | ||
|
|
||
| static BigIntVal hll_finalize(FunctionContext*, const StringVal& src); | ||
|
|
||
| static StringVal hll_serialize(FunctionContext* ctx, const StringVal& src); | ||
|
|
||
| static BigIntVal hll_cardinality(FunctionContext* ctx, const StringVal& src); | ||
| }; | ||
| } | ||
|
|
||
| #endif |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use a const or a macro, better not to use a magic number
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Use magic number only for simple.
Because I think we could delete this class code in doris 0.12 version.