Skip to content

Conversation

@bowenliang123
Copy link
Contributor

@bowenliang123 bowenliang123 commented Mar 10, 2023

Proposed changes

as the follwup for #17481

Problem summary

  • fix typo typos in Kyuubi doc
  • fix the wrong error path in examples

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Mar 10, 2023
@bowenliang123
Copy link
Contributor Author

cc @luzhijing

@bowenliang123
Copy link
Contributor Author

run buildall

Copy link
Contributor

@luzhijing luzhijing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 10, 2023
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@zhangguoqiang666
Copy link
Contributor

run p0

@luzhijing luzhijing merged commit a74ef23 into apache:master Mar 11, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. kind/docs Categorizes issue or PR as related to documentation. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants