Skip to content

Conversation

@caiconghui
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

  1. if be is dead and be ip not changed by FQDNManager,A situation may occur that after a while the old ip is used by other new alive pod,this may cause two be share same ip which is unexpected.
  2. when enable_fqdn is false, user can still set hostname in be when add backend

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

…void that active ip could be incorrectly assigned to dead be or fe
@caiconghui caiconghui changed the title [fix](fqdn) Add UnknownHostException handle logic in FQDNManager to avoid that active ip could be incorrectly assigned to dead be or fe [fix](fqdn) Add UnknownHostException handle logic in FQDNManager to avoid that active ip could be incorrectly assigned to dead be or dead fe Mar 11, 2023
@caiconghui
Copy link
Contributor Author

run buildall

@caiconghui caiconghui added k8s kind/fix Categorizes issue or PR as related to a bug. labels Mar 11, 2023
@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 11, 2023

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.26 seconds
stream load tsv: 469 seconds loaded 74807831229 Bytes, about 152 MB/s
stream load json: 39 seconds loaded 2358488459 Bytes, about 57 MB/s
stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230312094843_clickbench_pr_112940.html

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@caiconghui caiconghui added the approved Indicates a PR has been approved by one committer. label Mar 12, 2023
@caiconghui caiconghui merged commit a651926 into apache:master Mar 12, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
…void that active ip could be incorrectly assigned to dead be or dead fe (apache#17689)

1.if be is dead and be ip not changed by FQDNManager,A situation may occur that after a while the old ip is used by other new alive pod,this may cause two be share same ip which is unexpected.
2.when enable_fqdn is false, user can still set hostname in be when add backend

Co-authored-by: caiconghui1 <caiconghui1@jd.com>
@zddr zddr mentioned this pull request May 23, 2023
3 tasks
@caiconghui caiconghui deleted the fqdn branch June 13, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. k8s kind/fix Categorizes issue or PR as related to a bug. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants