Skip to content

[BugFix](DOE) Add http prefix when it's not set in hosts properties. #17745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
stalary merged 4 commits into from
Mar 21, 2023
Merged

[BugFix](DOE) Add http prefix when it's not set in hosts properties. #17745

stalary merged 4 commits into from
Mar 21, 2023

Conversation

@SaintBacchus
Copy link
Contributor

@SaintBacchus SaintBacchus commented Mar 13, 2023

Proposed changes

Issue Number: close #17722

Problem summary

Add http prefix when it's not set in hosts properties.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 13, 2023

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Mar 13, 2023 •
edited
Loading

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.81 seconds
stream load tsv: 465 seconds loaded 74807831229 Bytes, about 153 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 75 seconds loaded 1101869774 Bytes, about 14 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230319065929_clickbench_pr_116709.html

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 14, 2023

run p0

1 similar comment
@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 14, 2023

run p0

stalary
stalary reviewed Mar 14, 2023
View reviewed changes
@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 14, 2023

run buildall

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 14, 2023

run p0

1 similar comment
@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 15, 2023

run p0

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 15, 2023

run buildall

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 15, 2023

run p0

stalary
stalary previously approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@stalary stalary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stalary
Copy link
Contributor

stalary commented Mar 15, 2023

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 15, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 15, 2023

PR approved by anyone and no changes requested.

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 15, 2023

run p1

1 similar comment
@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 15, 2023

run p1

@stalary
Copy link
Contributor

stalary commented Mar 16, 2023

run p0

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 16, 2023

run p1

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 16, 2023

run p0

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 16, 2023

run p1

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 16, 2023

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Mar 16, 2023
@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 16, 2023

run clickbench

1 similar comment
@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 16, 2023

run clickbench

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 16, 2023

run p0

1 similar comment
@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 16, 2023

run p0

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 16, 2023

run clickbench

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 17, 2023

run p0

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 17, 2023

run clickbench

1 similar comment
@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 17, 2023

run clickbench

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 17, 2023

run p0

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 17, 2023

run buildall

2 similar comments
@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 17, 2023

run buildall

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 17, 2023

run buildall

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 18, 2023

run p0

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 18, 2023

run arm

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 18, 2023

run buildall

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 19, 2023

run buildall

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 19, 2023

run p0

2 similar comments
@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 19, 2023

run p0

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 20, 2023

run p0

@SaintBacchus
Copy link
Contributor Author

SaintBacchus commented Mar 20, 2023

run arm

stalary
stalary approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@stalary stalary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stalary stalary merged commit 4023670 into apache:master Mar 21, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@SaintBacchus @gnehil
[BugFix](DOE) Add http prefix when it's not set in hosts properties. (a…
51ef7e2 
…pache#17745)

* Add http prefix when it's not set in hosts properties
qidaye pushed a commit to qidaye/incubator-doris that referenced this pull request Aug 7, 2023
@SaintBacchus @qidaye
[BugFix](DOE) Add http prefix when it's not set in hosts properties. (a…
66f7313 
…pache#17745)

* Add http prefix when it's not set in hosts properties
@qidaye qidaye mentioned this pull request Aug 8, 2023
Merged
morningman pushed a commit that referenced this pull request Aug 8, 2023
@qidaye
[pick](DOE) pick doe fixes from master to branch-1.2-lts (#22685)
2bcf6c2 
PRs:
1. #17566 
2. #17412 
3. #17745 
4. #22279 
5. #22046 
6. #22423
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Sep 7, 2023
@qidaye
[pick](DOE) pick doe fixes from master to branch-1.2-lts (apache#22685)
9bc5fbf 
PRs:
1. apache#17566 
2. apache#17412 
3. apache#17745 
4. apache#22279 
5. apache#22046 
6. apache#22423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stalary stalary stalary approved these changes

Assignees

No one assigned

Labels

dev/1.2.3 kind/test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement] (DOE) hosts protocol access exception

4 participants

@SaintBacchus @hello-stephen @stalary @morningman