Skip to content

[fix](planner)fix failed to create view when use window function #17815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morrySnow merged 6 commits into from
Mar 24, 2023
Merged

[fix](planner)fix failed to create view when use window function #17815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3258d55
'fix-bugs'
sohardforaname Mar 15, 2023
ad5bd64
'fix-bugs'
sohardforaname Mar 15, 2023
84352a8
'fix-bugs'
sohardforaname Mar 15, 2023
0dae8af
'fix-bugs'
sohardforaname Mar 15, 2023
6b2be31
'fix-bugs'
sohardforaname Mar 15, 2023
c129f3f
'fix-bugs'
sohardforaname Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion fe/fe-core/src/main/java/org/apache/doris/analysis/SelectStmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@
import org.apache.doris.common.TreeNode;
import org.apache.doris.common.UserException;
import org.apache.doris.common.util.SqlUtils;
import org.apache.doris.common.util.ToSqlContext;
import org.apache.doris.qe.ConnectContext;
import org.apache.doris.rewrite.ExprRewriter;
import org.apache.doris.rewrite.mvrewrite.MVSelectFailedException;
Expand Down Expand Up @@ -2143,7 +2144,9 @@ private boolean checkSortNodeEliminable(Expr expr, List<SlotRef> sortSlotRefs) {
@Override
public String toSql() {
if (sqlString != null) {
return sqlString;
if (ToSqlContext.get() == null || ToSqlContext.get().isNeedSlotRefId()) {
return sqlString;
}
}
StringBuilder strBuilder = new StringBuilder();
if (withClause != null) {
Expand Down
8 changes: 8 additions & 0 deletions regression-test/suites/query_p0/sql_functions/window_functions/test_window_fn.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,6 +356,14 @@ suite("test_window_fn") {
from example_window_tb order by u_id;
"""

sql """
create view v as select row_number() over(partition by u_city order by u_salary) as wf from example_window_tb
"""

sql """
drop view v
"""

sql "DROP TABLE IF EXISTS example_window_tb;"
}

Expand Down