Skip to content

Conversation

@xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Mar 29, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

  1. Remove page cache regular clear
    Now the page cache is turned off by default. If the user manually opens the page cache, it can be considered that the user can accept the memory usage of the page cache, and then can consider adding a manual clear command to the cache.

  2. fix memory gc cancel top memory query

  3. jemalloc prof is not enabled by default

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Mar 29, 2023
@xinyiZzz
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz xinyiZzz changed the title [fix](memory) Remove page cache regular clear [fix](memory) Remove page cache regular clear, disabled jemalloc prof by default Mar 29, 2023
@morningman morningman added dev/1.2.4 usercase Important user case type label labels Mar 30, 2023
Copy link
Contributor

@yiguolei yiguolei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 01d012b into apache:master Mar 30, 2023
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
… by default (apache#18218)

Remove page cache regular clear
Now the page cache is turned off by default. If the user manually opens the page cache, it can be considered that the user can accept the memory usage of the page cache, and then can consider adding a manual clear command to the cache.

fix memory gc cancel top memory query

jemalloc prof is not enabled by default
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
… by default (apache#18218)

Remove page cache regular clear
Now the page cache is turned off by default. If the user manually opens the page cache, it can be considered that the user can accept the memory usage of the page cache, and then can consider adding a manual clear command to the cache.

fix memory gc cancel top memory query

jemalloc prof is not enabled by default
yagagagaga pushed a commit to yagagagaga/doris that referenced this pull request Mar 31, 2023
… by default (apache#18218)

Remove page cache regular clear
Now the page cache is turned off by default. If the user manually opens the page cache, it can be considered that the user can accept the memory usage of the page cache, and then can consider adding a manual clear command to the cache.

fix memory gc cancel top memory query

jemalloc prof is not enabled by default
morningman pushed a commit that referenced this pull request Apr 3, 2023
… by default (#18218)

Remove page cache regular clear
Now the page cache is turned off by default. If the user manually opens the page cache, it can be considered that the user can accept the memory usage of the page cache, and then can consider adding a manual clear command to the cache.

fix memory gc cancel top memory query

jemalloc prof is not enabled by default
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
… by default (apache#18218)

Remove page cache regular clear
Now the page cache is turned off by default. If the user manually opens the page cache, it can be considered that the user can accept the memory usage of the page cache, and then can consider adding a manual clear command to the cache.

fix memory gc cancel top memory query

jemalloc prof is not enabled by default
mongo360 pushed a commit to mongo360/doris that referenced this pull request Jul 12, 2023
… by default (apache#18218)

Remove page cache regular clear
Now the page cache is turned off by default. If the user manually opens the page cache, it can be considered that the user can accept the memory usage of the page cache, and then can consider adding a manual clear command to the cache.

fix memory gc cancel top memory query

jemalloc prof is not enabled by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev/1.2.4-merged kind/docs Categorizes issue or PR as related to documentation. usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants