Skip to content

[refactor](typesystem) using typeindex to create column instead of type name because type name is not stable #18328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 5 commits into from
Apr 9, 2023
Merged

[refactor](typesystem) using typeindex to create column instead of type name because type name is not stable #18328

yiguolei merged 5 commits into from
Apr 9, 2023

Conversation

@yiguolei
Copy link
Contributor

@yiguolei yiguolei commented Apr 3, 2023

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  • Does it affect the original behavior
  • Has unit tests been added
  • Has document been added or modified
  • Does it need to update dependencies
  • Is this PR support rollback (If NO, please explain WHY)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added area/sql/function Issues or PRs related to the SQL functions area/vectorization labels Apr 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei yiguolei force-pushed the remove_get_type_name branch from f52a236 to a4b0ed9 Compare April 3, 2023 08:24
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

4 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2023

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei
Copy link
Contributor Author

yiguolei commented Apr 3, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei
Copy link
Contributor Author

yiguolei commented Apr 4, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei
Copy link
Contributor Author

yiguolei commented Apr 4, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei yiguolei force-pushed the remove_get_type_name branch 2 times, most recently from 4c440f4 to 33d9a24 Compare April 8, 2023 03:45
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei yiguolei force-pushed the remove_get_type_name branch from 33d9a24 to 7875c51 Compare April 8, 2023 07:23
@yiguolei
Copy link
Contributor Author

yiguolei commented Apr 8, 2023

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

clang-tidy review says "All clean, LGTM! 👍"

Gabriel39
Gabriel39 approved these changes Apr 9, 2023
View reviewed changes
Copy link
Contributor

@Gabriel39 Gabriel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2023

PR approved by anyone and no changes requested.

@yiguolei
Copy link
Contributor Author

yiguolei commented Apr 9, 2023

skip failed test_mtmv_ssb_ddl

@yiguolei yiguolei merged commit f38e00b into apache:master Apr 9, 2023
gnehil pushed a commit to gnehil/doris that referenced this pull request Apr 21, 2023
@yiguolei @Doris-Extras @gnehil
[refactor](typesystem) using typeindex to create column instead of ty…
982007c 
…pe name because type name is not stable (apache#18328)


---------

Co-authored-by: yiguolei <yiguolei@gmail.com>
@TsukiokaKogane TsukiokaKogane mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriel39 Gabriel39 Gabriel39 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions area/vectorization kind/test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yiguolei @Gabriel39 @Doris-Extras