[Enchancement](compatible) show dateV2/datetimeV2 to date/datetime #18358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/planner
yiguolei
reviewed
Apr 4, 2023
Contributor
yiguolei
left a comment
yiguolei
left a comment
There was a problem hiding this comment.
Add regression test please.
morningman
changed the title
Contributor
|
Do not changing |
yiguolei
reviewed
Apr 7, 2023
| .addColumn(new Column("IndexKeysType", ScalarType.createVarchar(20))) | ||
| .addColumn(new Column("Field", ScalarType.createVarchar(20))) | ||
| .addColumn(new Column("Type", ScalarType.createVarchar(20))) | ||
| .addColumn(new Column("ColumnType", ScalarType.createVarchar(20))) |
yiguolei
reviewed
Apr 7, 2023
| "", | ||
| column.getName(), | ||
| column.getOriginType().toString(), | ||
| column.getOriginType().toString(), |
Contributor
Author
There was a problem hiding this comment.
是不是跟213 行重复了
不是，一个是替换后的type，一个是新加的InternalYype列
yiguolei
reviewed
Apr 7, 2023
| List<List<String>> res = new ArrayList<>(); | ||
| for (List<String> row : rows) { | ||
| // show DATEV2/DATETIMEV2 to DATE/DATETIME for compatibility | ||
| if (row.get(1).length() >= 6 && row.get(1).substring(0, 6).equals("DATEV2")) { |
Contributor
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
5 tasks
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
…pache#18358) show dateV2/datetimeV2 to date/datetime modify show create table modify desc table use desc table all to get real type from column ColumnType
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Problem summary
show dateV2/datetimeV2 to date/datetime
show create tabledesc tabledesc table allto get real type from columnColumnTypeChecklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...