[optimize](string) optimize split_by_string and substring_index function #18496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/sql/function
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
ZhangYu0123
force-pushed
the
optimize_splitbystring
branch
from
6861e4a to
6015919
Compare
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
Author
|
run arm |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
gnehil
pushed a commit
to gnehil/doris
that referenced
this pull request
Apr 21, 2023
…ion (apache#18496) Use SIMD stringsearcher and SIMD memcmp optimze split_by_string and substring_index function. split_by_string function has 32%~540% up substring_index function has 22%~46% up Performance difference depends on the needle size and whether the needle is constant param. And the longer the needle, the more performance improvement
Reminiscent
pushed a commit
to Reminiscent/doris
that referenced
this pull request
May 15, 2023
…ion (apache#18496) Use SIMD stringsearcher and SIMD memcmp optimze split_by_string and substring_index function. split_by_string function has 32%~540% up substring_index function has 22%~46% up Performance difference depends on the needle size and whether the needle is constant param. And the longer the needle, the more performance improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Use SIMD stringsearcher and SIMD memcmp optimze split_by_string and substring_index function.
Performance difference depends on the needle size and whether the needle is constant param. And the longer the needle, the more performance improvement
(1) split_by_string 32%~540% up
(2) substring_index 22%~46% up
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...